search

VernierST / godirect-py

A Python module for reading from Vernier Go Direct® Sensors using USB or BLE.
GNU General Public License v3.0
8 stars 9 forks source link

Fix timeout handling during read operation. #11

Closed Allandor closed 4 years ago

Allandor commented 4 years ago

The timout of the read operation was never hit, also the other timeout operation counted upwards.

stocktonkincade commented 4 years ago

Ah, yes! Those would be some very long timeouts. :) Good catch. We will review and include in the next release. Thank you.

stocktonkincade commented 4 years ago

@Allandor, can you please allow maintainers access to make commits to this pull request? We have a few changes that we would like to add. See: "Allowing changes to a pull request branch created from a fork." Thank you for your consideration and interest in this project.

Allandor commented 4 years ago

@stocktonkincade access for maintainers, should be enabled now.

stocktonkincade commented 4 years ago

@Allandor we moved your PR into #12 to fix a few things, so this PR can be closed. Thank you.