VernonStow / Filterlist

Blocklist for websites likely to be harmful or annoying, meant to supplement mainstream blocklists.
6 stars 1 forks source link

Incorrectly blocked domain - `blocklist.site` #1

Closed iam-py-test closed 3 years ago

iam-py-test commented 3 years ago

Your blocklist blocks blocklist.site, which is a safe domain that hosts antimalware lists for The Blocklist Project (not affiliation). This is due to the filter blocking all .site domains. Even with strict blocking disabled, it breaks the website https://www.virustotal.com/gui/url/c60e81d4c68ee96a9eae5d37ea4226dd46e82eafb022631d8a2e42770151a6ec/detection

VernonStow commented 3 years ago

Thank you, @iam-py-test

iam-py-test commented 3 years ago

@VernonStow Thanks for fixing this so quickly

iam-py-test commented 3 years ago

One question: How did you find the domains in this list? Just curious.

VernonStow commented 3 years ago

Some of the domains were listed in an article about a malware campaign, and others I observed while analyzing Twitter spam and phishing campaigns.

iam-py-test commented 3 years ago

@VernonStow Do you accept domain submissions? If so, should I open another issue or just make a pull request?

VernonStow commented 3 years ago

@iam-py-test I welcome domain submissions. Opening another issue would be fine, thanks.

iam-py-test commented 3 years ago

@VernonStow posted. Sorry I did not see your response earlier; I was busy.

iam-py-test commented 3 years ago

@VernonStow uBlock Origin shows it is invalid even thought it still works. I can switch it to ||site^$domain=~balabolka.site|~blocklist.site in my fork or you can make the change later

image

VernonStow commented 3 years ago

I fixed it, thanks. I wondered why it was showing in red even though the filter appeared to work properly.

iam-py-test commented 3 years ago

@VernonStow maybe it is a uBlock Origin bug. I can report it to uBlockOrigin/uBlock-Issues if you think it is

VernonStow commented 3 years ago

Probably more of a quirk than a bug. It should require the pipe to separate domains: https://github.com/gorhill/uBlock/wiki/Static-filter-syntax#domain