Vernoxvernax / Puddler-RS

Jellyfin & Emby & Plex command line client, powered by mpv. Written in Rust.
MIT License
14 stars 2 forks source link

Mark as watched. #2

Closed calmcacil closed 1 year ago

calmcacil commented 1 year ago

I ran into a problem that tends to prop up once in a while with anime sometime having very long ending sequences, and previews of the next episode where it ended up in marking some of my watched episodes at 86/89% not fully marking them as watched as far as puddler was concerned, now this is a minor inconvenience that requires going to the webui and marking as watched/unwatched. Mostly requesting this as i feel the spirit of puddler is to not have to go into the webui so being able to quickly fix this from file selection would be a great help.

Proposed solution When in episode list mode, accept something like mark entry to mark as watched and unmark entry to mark as unwatched, bonus point if it accepts multiple entries, potentially separated by commas or semi-colons, whichever feels more apt. i.e. mark 3,4,6 would mark episodes 2 3 and 5 as watched (as entries start at 0).

calmcacil commented 1 year ago

Additionally it would probably be nice to have a config value define when to mark an item as watched, i noticed that right now you see 90% and you mark it as watched, i think it'd be nice to move this 90% to a config setting just for those of us that watch a lot of content where 90% might be a little long.

Vernoxvernax commented 1 year ago

Ok I decreased the limit to 80%, which is still definitely acceptable for as watched state. Also, mark and unmark are now available. Please test them and see if they work for you as expected.

calmcacil commented 1 year ago

Unmarking works exactly as expected, marking as watched does not however trigger the mark as watched endpoint on emby so its not passed as watched to webhooks, should i file that as a new issue?

calmcacil commented 1 year ago

Nevermind, pebkac issue. Looks to work flawlessly.