search

VersBinarii / bme280-rs

A platform agnostic Rust driver for the Bosch BM[PE]-280
Other
59 stars 73 forks source link

Borrow Delay instead of transferring ownership #16

Closed jhodapp closed 2 years ago

jhodapp commented 2 years ago

Borrow Delay instead of transferring ownership which allows the Delay instance to still be used later in a program using the bme280 crate.

jhodapp commented 2 years ago

@VersBinarii Why did you close this PR?

VersBinarii commented 2 years ago

Its already in the code

jhodapp commented 2 years ago

Got it, so someone else made the fix and it's in master now?

VersBinarii commented 2 years ago

Its in master, yes. I took over the maintenance of it and already made code changes/other merges. It was easier for me to to just implement it myself than ask people to rebase 2 year old PRs ;)

jhodapp commented 2 years ago

Makes sense, thanks for the explanation and I'm glad someone has picked up maintaining this crate and hopefully improving it too.