search

Versent / saml2aws

CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP
https://github.com/Versent/saml2aws
MIT License
2.04k stars 556 forks source link

fix: enable cgo on macos builds #1243

Closed Meroje closed 3 months ago

Meroje commented 3 months ago

just like it's done on https://github.com/Versent/saml2aws/blob/master/.goreleaser.ubuntu-20.04.yml#L23-L24

fixes #900 #873

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.96%. Comparing base (9a4c5b6) to head (ba1cdc7). Report is 67 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1243 +/- ## ========================================== + Coverage 40.44% 41.96% +1.52% ========================================== Files 54 54 Lines 8276 6381 -1895 ========================================== - Hits 3347 2678 -669 + Misses 4491 3266 -1225 + Partials 438 437 -1 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `41.96% <ø> (+1.52%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jycamier commented 3 months ago

@mapkon is it possible to re-release macos releases ?

mapkon commented 3 months ago

Sure, I will attempt that tomorrow.

Mark

On Fri, 29 Mar 2024 at 19:25, Jean-Yves CAMIER @.***> wrote:

@mapkon https://github.com/mapkon is it possible to re-release macos releases ?

— Reply to this email directly, view it on GitHub https://github.com/Versent/saml2aws/pull/1243#issuecomment-2026938384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGQV5PGAPF7BOK2KRIQ2QTY2UQRLAVCNFSM6AAAAABFHHSVUGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWHEZTQMZYGQ . You are receiving this because you were mentioned.Message ID: @.***>

mapkon commented 3 months ago

@mapkon is it possible to re-release macos releases ?

Done!

jycamier commented 3 months ago

Thank you !