Versent / saml2aws

CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP
https://github.com/Versent/saml2aws
MIT License
2.07k stars 563 forks source link

Fixing saved credential issue for --credential-process introduced by https://github.com/Versent/saml2aws/pull/896 #1274

Closed timharris777 closed 4 months ago

timharris777 commented 4 months ago

PR to address this: https://github.com/Versent/saml2aws/issues/895#issuecomment-2117464337

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 41.89%. Comparing base (16a69e6) to head (1af5aca). Report is 16 commits behind head on master.

Files Patch % Lines
cmd/saml2aws/commands/login.go 40.00% 8 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1274 +/- ## ========================================== - Coverage 41.93% 41.89% -0.04% ========================================== Files 54 54 Lines 6386 6425 +39 ========================================== + Hits 2678 2692 +14 - Misses 3271 3291 +20 - Partials 437 442 +5 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1274/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1274/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `41.89% <40.00%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.