Versent / saml2aws

CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP
https://github.com/Versent/saml2aws
MIT License
2.09k stars 563 forks source link

add okta email mfa support #1281

Closed tmesgong closed 5 months ago

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.23%. Comparing base (54e1e97) to head (37f0b63). Report is 5 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1281 +/- ## ========================================== + Coverage 42.08% 42.23% +0.15% ========================================== Files 54 54 Lines 6442 6442 ========================================== + Hits 2711 2721 +10 + Misses 3288 3274 -14 - Partials 443 447 +4 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1281/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `42.23% <100.00%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mapkon commented 5 months ago

@tmesgong the linter is failing.

tmesgong commented 5 months ago

@mapkon I don't know how to test. It works for me. I follow the okta sms mfa code, but it doesn't have test. If there's similar test I can follow, I'd like add this later.