Versent / saml2aws

CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP
https://github.com/Versent/saml2aws
MIT License
2.09k stars 564 forks source link

update error message to align with playwright-go update #1299

Closed charlottecampbell193 closed 5 months ago

charlottecampbell193 commented 5 months ago

New version of playwright-go 'run.go' file added a check on if the driver is up to date. Updated TestNoBrowserDriverFail in browser_test.go to look for the new error message.

    driver, err := NewDriver(transformRunOptions(options))
    if err != nil {
        return nil, fmt.Errorf("could not get driver instance: %w", err)
    }
    **up2date, err := driver.isUpToDateDriver()
    if err != nil || !up2date {
        return nil, fmt.Errorf("please install the driver (v%s) and browsers first: %w", playwrightCliVersion, err)
    }**
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.19%. Comparing base (99d6fe4) to head (ed387cc). Report is 14 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1299 +/- ## ======================================= Coverage 42.19% 42.19% ======================================= Files 54 54 Lines 6456 6456 ======================================= Hits 2724 2724 Misses 3283 3283 Partials 449 449 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1299/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1299/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `42.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.