codecov-commenter
commented
4 months ago :warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 42.19%. Comparing base (
99d6fe4) to head (2afa50b). Report is 47 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #1317 +/- ## ======================================= Coverage 42.19% 42.19% ======================================= Files 54 54 Lines 6456 6456 ======================================= Hits 2724 2724 Misses 3283 3283 Partials 449 449 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `42.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
A change made between v2.36.15 to v2.36.16 (current version at time of writing) had introduced an unwanted side-effect of not showing MFA phone numbers when using the
--credential-processflag as it also implicitly applies--quiet.The line in question that was introduced by a commit that made it into v2.36.16 is https://github.com/Versent/saml2aws/blob/08035b93069c0ca518b13d1ef905e08b95bc1269/cmd/saml2aws/main.go#L172
Looking at the PR https://github.com/Versent/saml2aws/commit/08035b93069c0ca518b13d1ef905e08b95bc1269#diff-700f078cb6e14d20af7c09e73a1507604a85cfb66d6c54db727f45dc21a13d2a, I do not see any potential side-effects in removing the additional conditions in the "quiet" condition statement to "quiet" the logs.