Versent / saml2aws

CLI tool which enables you to login and retrieve AWS temporary credentials using a SAML IDP
https://github.com/Versent/saml2aws
MIT License
2.09k stars 564 forks source link

fix: gha setup go cache issue [#1319] #1320

Closed tinaboyce closed 4 months ago

tinaboyce commented 4 months ago

While looking at the GitHub Action runner executing a job, I have noticed an error during the "Set up Go 1.x" stage

Warning: Restore cache failed: Dependencies file is not found in /home/runner/work/saml2aws/saml2aws. Supported file pattern: go.sum

A quick look at the documentation and it had the actions/checkout before the actions/setup-go, while we had it afterwards, which probably explains why it cannot find go.sum.

Also (the bit that was outside the scope of the initial issue but I wanted to save multiple PRs):

I am more than happy to move the "also" bit to a new PR if that is more ideal?

Closes #1319

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 42.19%. Comparing base (99d6fe4) to head (36c8b29). Report is 50 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1320 +/- ## ======================================= Coverage 42.19% 42.19% ======================================= Files 54 54 Lines 6456 6456 ======================================= Hits 2724 2724 Misses 3283 3283 Partials 449 449 ``` | [Flag](https://app.codecov.io/gh/Versent/saml2aws/pull/1320/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Versent/saml2aws/pull/1320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent) | `42.19% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Versent#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mapkon commented 4 months ago

I still prefer formatting changes to be separate from material changes.