VertNet / webapp

VertNet web application
8 stars 7 forks source link

Data issue submit "undefined" in text rather than record information #497

Closed tucotuco closed 10 years ago

tucotuco commented 10 years ago

Been testing submitting issues today. None of them include the data when they arrive in Github. Instead, there is a link to the portal and "undefined" in place of the data.

laurarussell commented 10 years ago

Did some checking with issues sitting in my Inbox. July 1 still working properly (https://github.com/cm-vertnet/cm-herps/issues/3). By July 25, no longer working properly (https://github.com/ku-vertnet/kubi-ichthyology/issues/4).

laurarussell commented 10 years ago

Reviewed commits during this time period. My guess would be the commits agains detail.js over any of the html commits to detail, but potentially could be detail.hmtl as well.

models/detail.js https://github.com/VertNet/webapp/commit/d2b8b29ffcd9eeb4d64f8c24ed91372d2600df05

models/detail.js (merge) https://github.com/VertNet/webapp/commit/3d84ca6f74b0d83fde36c0930670776195d36c1d

views/detail.html https://github.com/VertNet/webapp/commit/cd6def30da8de09d29ae473f4e3aaf899a0b37ca#diff-d6375cadbbb50647cb591d46b8abcf18R216

views/detail.html (merge) https://github.com/VertNet/webapp/commit/de9b213c64016e859410d3dbef99e5e5fcf75a91

laurarussell commented 10 years ago

Been looking at these and I don't think any of the changes would cause the data submit issue. Maybe something about the github api changed.

laurarussell commented 10 years ago

Okay, more research. I think it is because the tableID alltable (at https://github.com/VertNet/webapp/blob/ec6fae53ad7a615688d37a8dd8300a020ea3ec64/www/js/app/views/detail.html#L338) is commented out in this section.

I think if we replace https://github.com/VertNet/webapp/blob/ec6fae53ad7a615688d37a8dd8300a020ea3ec64/www/js/app/views/detail.html#L128

with

That should fix up this issue because the issue body is looking for a tableID="alltable". What do you think?

tucotuco commented 10 years ago

Fixed in 699315c1e225e851e6ef0e8bc4891e327d90967c, confirmed in https://github.com/rom-vertnet/herpetology/issues/14.