Vertafore / docular

AngularJS based documentation generation: Extensible, customizable parsing and partial generation
MIT License
165 stars 35 forks source link

changed regexes in doc.js to match replace from : to _ #110

Closed idanbauer closed 10 years ago

idanbauer commented 10 years ago

@stephenliberty

In major rewrite part 1 you ran a replace from ":" to "_" (I'm assuming to fix a windows file system issue?) In any case, there are regexes in docs.js that rely on the column to match and match the wrong string. This breaks the grouping functionality in the API sections (see the Angular docs directives in a generated site).

I fixed the regexes to check for underscores as well as columns.

stephenliberty commented 10 years ago

Thanks. I found this in the development branch, but my fix was wrapped up in so many other changes it wasn't really plausible to merge at that moment.