Vertex3 / gseUW

University of Washington Gizinta Sync Engine
Other
0 stars 0 forks source link

Multiple rooms being created for a floor #22

Open SteveGrise opened 7 years ago

SteveGrise commented 7 years ago

Looking at 1181_01 I am getting a triplicate of every room. One load from 4/25, another from 7/6 and a third where the source drawing is the outline.

SteveGrise commented 7 years ago

When you look at the workbench file, it looks like the fme reader in gseFloorplanLoader is just reading the FloorPageTemplate feature class, but it is reading that plus the floor view: image The FeatureMerger is not processing duplicate suppliers, so it is hard to imagine how multiple features could be created unless there are multiple features in the source drawing: image The floorpagetemplate geometry is used by the tilt transformers that create the isometric features during processing.

SteveGrise commented 7 years ago

In the database I just see one row for floorpagetemplate: image and floor: image

SteveGrise commented 7 years ago

@aaronch since the data looks different than what you experienced maybe you can make sure we are talking about the same thing? I'm looking at maps.uw.edu and the uwCadSde database.

Also I'd like to get the CAD drawing for testing purposes, maybe you can show me how to grab files from the vault at some point.

SteveGrise commented 7 years ago

But there are duplicates in the InteriorSpace table: image

SteveGrise commented 7 years ago

It looks like there is an issue in the delta views, this is only showing 1 row for each space: image

SteveGrise commented 7 years ago

It appears that the last drawing run on staging was 1008_03. In the feature class I do see duplicate records: image Actually they are not duplicates, some have NULL values for things that should have happened in the field calculator.

SteveGrise commented 7 years ago

There are 2 parts of the fme process that are suspect: There is an unfiltered branch in the tester that routes floor areas, floorplanlines, and interiorspaces. Could that be passing through these features? There is also a piece of logic inside the catwalk remover for interiorspaces the should never be reached, but some features could pass through that.

Will need to test with the source drawings and verify in fme that there are no issues. It appears something is happening in the fme process and the other parts of the system appear to be incorrect but they are symptoms.

SteveGrise commented 7 years ago

It is strange that the dates are so different and other attributes also have changes: image

SteveGrise commented 7 years ago

The fme process is creating the right number of rows when run from fme workbench: image

But adding 56 rows instead of 29 when run from windows script: image

SteveGrise commented 7 years ago

I changed the fp\fpInteriorSpace.xml source from RMS to InteriorSpace. That seems to clear up the number of features being written.

SteveGrise commented 7 years ago

I removed the duplicates. I noticed that if there were dups you had to run the same drawing 2x to clean it up... so it should be ok now.

So the root issue was that the fpInteriorSpace config file had RMS as the source, changing that to InteriorSpace solved the problem. There are 3 things that bug me about this: