Conflict with Info Display Extension mod

VertexFloat / additionalUnits

Additional Units mod for Farming Simulator

https://www.farming-simulator.com/mod.php?mod_id=268900&title=fs2022

GNU General Public License v3.0

8 stars 2 forks source link

Conflict with Info Display Extension mod #5

Closed vitalii2011 closed 5 months ago

vitalii2011 commented 1 year ago

https://www.farming-simulator.com/mod.php?lang=en&country=ru&mod_id=239604&title=fs2022
The name "Liters" cannot be edited (in game)?
Is it possible to add space for 2 characters in the 'Short name' field?

KingArthurLV commented 1 year ago

I can canfirm, that I have same issue. Information about capacity also disapeared in production, animal pens and storage menus.

4c65736975 commented 1 year ago

I'll check it out, I think some of the overrides conflict with the overrides of this extension or I just need to override the Info Display extension's functions.
Yes, it's not possible because it's the default unit of the game and I've disabled the option to edit it.
Yes, it's possible I just didn't thought that short name could be so long :D

vitalii2011 commented 1 year ago

:) That's right. There is no abbreviation for "pound" in Russian.

vitalii2011 commented 1 year ago

Maybe it would be correct to add a "default" space before all "shortName"?
Units of measure are not "picked up" in the Target Fill Level mod https://www.farming-simulator.com/mod.php?mod_id=231717 .

4c65736975 commented 1 year ago

It has default spacing.
I will add compatibility with this in upcoming update.

4c65736975 commented 5 months ago

Due to the need to change the core InfoDisplayExtension elements for support, no support has been added for this modification.

Support added for TargetFillLevel and StrawHarvestPack

4c65736975 commented 5 months ago

Beta version of InfoDisplayExtension has been released, support for the AdditionalUnits mod has been added. Download this version to test it out.

vitalii2011 commented 5 months ago

InfoDisplayExtension 1.7.1.1 without Additional Units 1.0.0.1: fsScreen_2024_04_07_08_57_10 With: fsScreen_2024_04_07_08_52_41

4c65736975 commented 5 months ago

InfoDisplayExtension 1.7.1.1 without Additional Units 1.0.0.1: With: log.txt

Do you have any other modifications related to ProductionPoints enabled? Because it looks like a conflict with one

vitalii2011 commented 5 months ago

Only InfoDisplayExtension 1.7.1.1 and Additional Units 1.0.0.1, when turn on production, the HUD stops displaying:

https://github.com/VertexFloat/additionalUnits/assets/41552153/d8ed52bd-c602-4bf4-9a45-6e602fa886fb

4c65736975 commented 5 months ago

Only InfoDisplayExtension 1.7.1.1 and Additional Units 1.0.0.1, when turn on production, the HUD stops displaying:

FarmingSimulator2022Game.2024-04-07.11-50-20.mp4 log.txt

It looks like something is wrong on your end, because everything works fine for me. Please check it on a clean savegame with only these two modifications

vitalii2011 commented 5 months ago

Unfortunately, even this: fsScreen_2024_04_07_12_49_25 same problem: modSettings.zip

4c65736975 commented 5 months ago

Unfortunately, even this: mods.zip same problem: modSettings.zip log.txt

Fixed, let me know if now everything works fine ;) v1.0.0.1

vitalii2011 commented 5 months ago

Everything seems to be fine. Thanks!

vitalii2011 commented 5 months ago

But now the abbreviated names of units of measurement are not displayed.

4c65736975 commented 5 months ago

But now the abbreviated names of units of measurement are not displayed.

Yeah I know, the problem was with my implementation of support in InputDisplayExtension, download this version and it should works.

I already opened pull request.

vitalii2011 commented 5 months ago

I haven’t seen any problems with Info Display Extension 1.7.1.2 (yet ;) ). Thanks.