Closed derpda closed 2 years ago
Thank you for merging the last PR! I was away on the weekend, so I apologize for the late response.
As promised, here is the PR addressing issues #8 and #9, making modifications to the CMake code. With this PR, the configure step will
EIGEN_VERSION
INTERFACE_INCLUDE_DIRECTORIES
bytetrack
This makes it significantly easier to use ByteTrack from other CMake projects (as is my use case).
In the mean time, I have been making more drastic changes to the main code, since it looks like I will be using this library quite intensively.
Namely I have
clang-format
ByteTrack::update
new
delete
lapjv
std::vector
Object
STrack
const int&
as well as some other minor changes.\ None of those changes are in this PR, but if you are interested I could make additional PRs.
Thanks! I've been very busy and am sorry for the delay in responding.
Thank you for merging the last PR! I was away on the weekend, so I apologize for the late response.
As promised, here is the PR addressing issues #8 and #9, making modifications to the CMake code. With this PR, the configure step will
EIGEN_VERSION
variable, here set to 3.3INTERFACE_INCLUDE_DIRECTORIES
on thebytetrack
targetThis makes it significantly easier to use ByteTrack from other CMake projects (as is my use case).
Side note
In the mean time, I have been making more drastic changes to the main code, since it looks like I will be using this library quite intensively.
Namely I have
clang-format
and committed that configuration fileByteTrack::update
method for (what I think is) better readabilitynew
anddelete
for thelapjv
invocation and replaced it withstd::vector
Object
class, integrating it into theSTrack
classconst int&
or other constant primitive references, as these have no benefitas well as some other minor changes.\ None of those changes are in this PR, but if you are interested I could make additional PRs.