Vertispan / j2clmavenplugin

Maven plugin to launch new J2CL compilation
https://vertispan.github.io/j2clmavenplugin/
Apache License 2.0
53 stars 26 forks source link

generate resulted xtb file made of parent locales and all other suita… #183

Closed treblereel closed 2 years ago

treblereel commented 2 years ago

…ble xtb files, provide it to closure

niloc132 commented 2 years ago

Lots of warnings in the build like this:

[WARNING] translation.test:default:1.0/transpiled_js: Warning:UnescapedAndEscapedCheck.java:5: [unusable-by-js] Native 'String UnescapedAndEscapedCheck.test2(String arg)' is exposed to JavaScript without @JsMethod.

Is this just an artifact of how the tests are written, won't affect normal users?

niloc132 commented 2 years ago

Wrong warning?

[INFO] Finished translation.test:cz:1.0/transpiled_js in 39ms
[INFO] Starting translation.test:cz:1.0/optimized_js
[WARNING] translation.test:cz:1.0/optimized_js: translationsFile only works in the ADVANCED optimization level, in other levels the default messages values will be used
[INFO] translation.test:cz:1.0/optimized_js: 0 error(s), 0 warning(s), 97.7% typed

[INFO] Finished translation.test:cz:1.0/optimized_js in 5466ms
[INFO] Starting final task translation.test:cz:1.0/optimized_js
[INFO] Finished final task translation.test:cz:1.0/optimized_js in 3ms
[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ cz ---
[INFO] Building jar: /home/colin/workspace/j2clmavenplugin/j2cl-maven-plugin/target/it-tests/translationsfile/tests/target/cz-1.0.jar
[INFO] 
treblereel commented 2 years ago

Lots of warnings in the build like this:

[WARNING] translation.test:default:1.0/transpiled_js: Warning:UnescapedAndEscapedCheck.java:5: [unusable-by-js] Native 'String UnescapedAndEscapedCheck.test2(String arg)' is exposed to JavaScript without @JsMethod.

Is this just an artifact of how the tests are written, won't affect normal users?

nope, it's a test, let me add @JsMethod decls into it to make it happy