When a task is ready to run and enqueued, mark it as started right away

Vertispan / j2clmavenplugin

Maven plugin to launch new J2CL compilation

https://vertispan.github.io/j2clmavenplugin/

Apache License 2.0

53 stars 26 forks source link

When a task is ready to run and enqueued, mark it as started right away #187

Closed niloc132 closed 2 years ago

niloc132 commented 2 years ago

This solves a bug where a task might be enqueued in the executor service for longer than the stale timeout, so the cache believes that the running task is in fact stale/canceled, and attempts to cancel it, but this races against the task actually starting and trying to use the files it expected to have access to.

Fixes #186

niloc132 commented 2 years ago

To test this, the stale age and update interval can be sped up by setting these in MAVEN_OPTS: -Dj2cl.diskcache.max_stale_age=1 -Dj2cl.diskcache.mark_active_update_delay_ms=500