search

VeruGHub / easyclimate

Easy access to high-resolution daily climate data for Europe
https://verughub.github.io/easyclimate/
GNU General Public License v3.0
45 stars 1 forks source link

Converting values to ºC and mm automatically? #29

Closed Pakillo closed 2 years ago

Pakillo commented 2 years ago

Some users might be confused that values are in ºC100 and mm100 for temperature and precipitation, respectively. Shall we return the values already in ºC and mm? Obviously the conversion it's very easy to do within the function.

The only disadvantage I can think of right now is increased memory use if you want to save a lot of these data... But in those cases the users could always multiply by 100 to avoid floating values again? I think the majority of users will want to work with ºC and mm directly...

VeruGHub commented 2 years ago

I agree that returning the values in ºC and mm is easier for the user. And make things easy to others is the philosophy here...

Pakillo commented 2 years ago

Alright. Let's make the change then, to return values in ºC and mm. This change will break most tests, so we need to update them too (just dividing the values in the tests by 100, or multiplying by 0.01)