VeruGHub / easyclimate

Easy access to high-resolution daily climate data for Europe
https://verughub.github.io/easyclimate/
GNU General Public License v3.0
45 stars 1 forks source link

Update March 2021 #4

Closed VeruGHub closed 3 years ago

VeruGHub commented 3 years ago

Dear all, I have uploaded a new version of the package. Functions are now in separated files in the folder 2R/functions. @Julenasti and me write them in roxygen format. It is possible to call all functions with 2R/99_main.R and run an example. I have assigned some tasks for the next steps but, please, let me know if you can not do them during the next weeks and we'll see how to organize the work :)

VeruGHub commented 3 years ago

I forget to say that I add an "@author" field in the functions because of the roxygen format, but I am not sure about the meanning. Should we all be the authors of all functions? and in this case: it is necessary to specify it in every function? Maybe some of you that have more experience could shed light in this issue :)

Pakillo commented 3 years ago

Hi, Thanks @VeruGHub, looks like you made a lot of progress! Let me know when you are done with the other reviews and we can start moving things around. The structure of the repo is going to change quite a lot, do you want me to work on a different branch or directly on the master? Regarding authors, you can if you want to, but you don't need to include that info in every function. Just naming authors in the DESCRIPTION file (once we have the package) should be enough. Especially because it's hard to track contributions to individual functions. But up to you @VeruGHub if you wish we can have a videochat to discuss the main changes we need to make, before I start uploading commits messing up everything :)

VeruGHub commented 3 years ago

Hi everybody! After talking to @Pakillo, we have decided that the best way to continue is by working in the master and overwrite it, so it is going to be reestructured. If someone wants to review the functions during the next days, please, contact me and I can indicate the best way to do it to not create conflictive commits.