search

VerusCoin / Verus-Mobile

The iOS/Android Verus Mobile cryptocurrency wallet.
MIT License
157 stars 78 forks source link

Notifications Widget #146

Closed monkins1010 closed 9 months ago

monkins1010 commented 11 months ago

Hi Chris, the changes are good, and I was able to fit in a quick review today (will take another more detailed look tomorrow), so I added comments into the code, and aside from some style comments, had a few functionality notes/questions (again, more detail in code):

  1. It seems we're still waiting for provisioned IDs marked as completed by making the user sit while the tx confirms. It would be ideal if these were handled with notifications similarly to how the pending IDs are.
  2. I'm a little confused about how an ID is represented before it is ready for the user to take action on, as it seems only deepink notifications are being dispatched.

Feel free to contact me for any more verification/in depth discussion, and thanks for the prompt changes.

  • Michael

Hi Chris, the changes are good, and I was able to fit in a quick review today (will take another more detailed look tomorrow), so I added comments into the code, and aside from some style comments, had a few functionality notes/questions (again, more detail in code):

  1. It seems we're still waiting for provisioned IDs marked as completed by making the user sit while the tx confirms. It would be ideal if these were handled with notifications similarly to how the pending IDs are.
  2. I'm a little confused about how an ID is represented before it is ready for the user to take action on, as it seems only deepink notifications are being dispatched.

Feel free to contact me for any more verification/in depth discussion, and thanks for the prompt changes.

  • Michael

C1) ID's marked with pending will exit out straightaway and be handled by the notifications. Yes ID's marked as complete await the transfer, and yes this could be up to 10 mins on a slow block so Ill make that exit out back to home screen so its not C2) Yes a pending ID only exists in the background as data, not sure if the Joe123@ Is being created notification is necessary? if so can implement.