chore: optimize Request.read

VeryGoodOpenSource / dart_frog

A fast, minimalistic backend framework for Dart 🎯

https://dartfrog.vgv.dev

MIT License

1.79k stars 150 forks source link

chore: optimize Request.read #1410

Open kevmoo opened 1 week ago

kevmoo commented 1 week ago

Status

READY

Description

Use Expando instead of cloning each request.

Should improve performance. Should be measured.
Allows nested _request to be final. (Potentially allows future use of extension type

Type of Change

[ ] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠️ Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[x] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑️ Chore

kevmoo commented 1 week ago

@felangel – enable CI workflows?

felangel commented 1 week ago

@felangel – enable CI workflows?

I’m not part of the organization anymore so I don’t have permissions unfortunately. @wolfenrain @alestiago can help 👍

tomarra commented 6 days ago

Hi @kevmoo 👋 Thanks for opening this PR. Would you be able to fill in the description of the PR with more details on what the goal of this change is and how it accomplishes that? I added our normal PR template back into the description so all you should need to do is fill out the description section with those details for us to do a proper review.

kevmoo commented 5 days ago

@tomarra – done!

kevmoo commented 1 day ago

Do ya'll have benchmarks we could look at?