Support for Http2 - Githubissues

VeryGoodOpenSource / dart_frog

A fast, minimalistic backend framework for Dart 🎯

https://dartfrog.vgv.dev

MIT License

1.85k stars 147 forks source link

Support for Http2 #1502

Open markbreuss opened 1 month ago

markbreuss commented 1 month ago

Description

I am currently facing an issue that google cloud run has a response size limit of 32Mib Wich is not enough for our PDF reports.

The solution would be to switch over to http2:

As soon as I switch it, the bacckend does not work anymore.

My question is, does dartfrog support it? If yes, do you have any ressources to point me to on how to set it up. If no, are there any plans to support it?

Thanks for the help,

Mark

Requirements

[ ] All CI/CD checks are passing.
[ ] There is no drop in the test coverage percentage.

Additional Context

No response

tomarra commented 3 weeks ago

Hi @markbreuss 👋 Thanks for opening this issue!

We did a bit of research on this and overall it seems like Dart/Shelf needs some more effort on this before we can pull it in to use for Dart Frog. While there is a Dart package for http2 it seems that the effort to pull this into shelf has had an open ticket since 2015, https://github.com/dart-lang/shelf/issues/50

We will follow up with the Dart team on this to see if there is any progress from their side as a next step.

tomarra commented 1 week ago

Given the update from the Dart team on https://github.com/dart-lang/shelf/issues/50 it seems like this is something that they are not looking to add to shelf and would have to be a custom implementation. As we don't have a use case for this currently I'm going to leave it open as a P3 so if someone would like to work on it they could but it's not on our priority list at this time.