VeryGoodOpenSource / flutter_web_preloader

A brick that creates a smart web entrypoint for Flutter and preloads any type of asset before starting an app.
https://brickhub.dev/bricks/flutter_web_preloader/0.2.0
MIT License
77 stars 7 forks source link

chore: Removes duplicate script from index.html #24

Closed cgutierr-zgz closed 7 months ago

cgutierr-zgz commented 7 months ago

The script setting serviceWorkerVersion was duplicated inside the body.

Status

READY

Description

Removes duplicate script

<script>
  // The value below is injected by flutter build, do not touch.
  const serviceWorkerVersion = null;
</script>

Type of Change

tomarra commented 7 months ago

@erickzanardo any reason why we had this defined in the body as well? I just did made a new flutter app and in the web target it only has it defined in the head tag so this seems like something we maybe added on purpose?

erickzanardo commented 7 months ago

@erickzanardo any reason why we had this defined in the body as well? I just did made a new flutter app and in the web target it only has it defined in the head tag so this seems like something we maybe added on purpose?

@tomarra I can't think in any reason. This seems mostly likely a mistake, makes no sense to have it duplicated like that as far as I can think.