search

VeryGoodOpenSource / very_good_analysis

Lint rules for Dart and Flutter used internally at Very Good Ventures 🦄
https://pub.dev/packages/very_good_analysis
MIT License
369 stars 38 forks source link

Add latest lint rules #98

Closed lishaduck closed 5 months ago

lishaduck commented 5 months ago

Is your feature request related to a problem? Please describe. It gets annoying to turn on rules when upgrading version, as I expect VGA to handle it.

Describe the solution you'd like Add the following in VGA 5.2.0:

no_wildcard_variable_uses: true
no_self_assignments: true
annotate_redeclares: true
missing_code_block_language_in_doc_comment: true
unnecessary_library_name: true

# package:lints removed these as unnecessary_library_name make them useless.
library_names: false
package_prefixed_library_names: false

Describe alternatives you've considered Continue applying them myself.

Additional context This package hasn't been updated for Dart 3.2+. When using VGA for strict analysis, one now has to manually add in rules, rather than just relying on this package for coverage. It's not a big deal, but it is a bit annoying.

I'd be willing to PR here if you'd like.

lishaduck commented 5 months ago

v6 is merged now, so I think this can be closed.