search

VeryGoodOpenSource / very_good_cli

A Very Good Command-Line Interface for Dart created by Very Good Ventures 🦄
http://cli.vgv.dev
MIT License
2.15k stars 189 forks source link

fix: Reporting of malformed licenses #1016

Open dominicmh opened 5 months ago

dominicmh commented 5 months ago

Description very_good packages check licenses fails to report pubs with unknown licenses (e.g. rxdart):

$ very_good packages check licenses
✓ Retrieved 0 licenses from 1 package. (0.7s)

Steps To Reproduce

  1. Clone example repo (includes rxdart dependency in pubspec.lock)
  2. Execute dart pub global activate very_good_cli; very_good packages check licenses

Expected Behavior ✓ Retrieved 1 license from 1 package of type: unknown (1).

Actual Behavior ✓ Retrieved 0 licenses from 1 package.

alestiago commented 4 months ago

Hi @dominicmh thanks for opening an issue! And sorry for the late reply, I haven't been able to catch-up recently.

I've been able to reproduce this issue by using the following pubspec.yaml.

puspec.yaml ```yaml name: example description: An example project. version: 1.0.0+1 publish_to: none environment: sdk: "^3.3.0" dependencies: rxdart: ^0.27.7 ```

@dominicmh are you interested in contributing with a fix? If so, let me know and I can assign you to this item and assist you on landing it 🙌

dominicmh commented 4 months ago

Hi @alestiago – I can't really promise any delivery date, could be weeks or even months. But generally I'm open to fix this.