VeryGoodOpenSource / very_good_cli

A Very Good Command-Line Interface for Dart created by Very Good Ventures 🦄
http://cli.vgv.dev
MIT License
2.15k stars 188 forks source link

style: AndroidManifest.xml's '<application' opening tag is indented by 3 spaces instead of 4 #1066

Closed MrCsabaToth closed 3 months ago

MrCsabaToth commented 3 months ago

Description The generated AndroidManfiest.xml has one less space for the indentation of the <application opening tag, whereas the </application> closing tag has the proper four spaces.

Steps To Reproduce

  1. very_good create flutter_app my_app
  2. cd my_app/android/src/main/
  3. cat AndroidManfiest.xml
  4. 3rd line is the opening tag

Expected Behavior Both the opening and the closing tag would have four spaces of indentation

Exhibit

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.example.verygoodcore.my_app">
   <application
        android:label="${appName}"
        android:name="${applicationName}"
        android:icon="@mipmap/ic_launcher">
        <activity
            android:name=".MainActivity"
            android:exported="true"
            android:launchMode="singleTask"
            android:theme="@style/LaunchTheme"
            android:configChanges="orientation|keyboardHidden|keyboard|screenSize|smallestScreenSize|locale|layoutDirection|fontScale|screenLayout|density|uiMode"
            android:hardwareAccelerated="true"
            android:windowSoftInputMode="adjustResize">
            <!-- Specifies an Android theme to apply to this Activity as soon as
                 the Android process has started. This theme is visible to the user
                 while the Flutter UI initializes. After that, this theme continues
                 to determine the Window background behind the Flutter UI. -->
            <meta-data
              android:name="io.flutter.embedding.android.NormalTheme"
              android:resource="@style/NormalTheme"
              />            
            <intent-filter>
                <action android:name="android.intent.action.MAIN"/>
                <category android:name="android.intent.category.LAUNCHER"/>
            </intent-filter>
        </activity>
        <!-- Don't delete the meta-data below.
             This is used by the Flutter tool to generate GeneratedPluginRegistrant.java -->
        <meta-data
            android:name="flutterEmbedding"
            android:value="2" />
    </application>
</manifest>

Additional Context I'll try to craft a PR.

MrCsabaToth commented 3 months ago

The Flame Game and Flutter Plugin creation is affected as well, plus the Wear app creation had a different similar (one space missing) indentation for the com.google.android.wearable.standalone meta-data tag, the PR addresses those.

tomarra commented 3 months ago

This got moved over to https://github.com/VeryGoodOpenSource/very_good_templates/issues/125 so closing this out as won't fix