VeryGoodOpenSource / very_good_cli

A Very Good Command-Line Interface for Dart created by Very Good Ventures 🦄
http://cli.vgv.dev
MIT License
2.2k stars 196 forks source link

feat: Dockerize the project #1162

Open a-wallen opened 1 month ago

a-wallen commented 1 month ago

Description

I'm developing on a windows machine, and tests for this project fail out of the box due to the difference in path separators on the host machine "\" vs "/".

  1. One way to resolve this issue is to use something like 'Platform.pathSeparator'. Right now, it seems like "/" is hardcoded in some areas.

  2. Another way to resolve this is to dockerize the project

Requirements

Additional Context

No response

tomarra commented 1 month ago

HI @a-wallen, thanks for opening this issue up.

Overall I don't think that dockerizing the project is a direction we want to go. That being said I think the path separators point is something we can address and probably should to ensure compatibility across systems.

Do you have a list of specific tests that are failing for you that we could start to narrow the search for these hardcoded values on? Overall we don't do much if any development on Windows so we don't tend to run into these issues.