VeryGoodOpenSource / very_good_flame_game

A Very Good Flutter Starter Flame Game created by the Very Good Ventures Team ๐Ÿฆ„
https://brickhub.dev/bricks/very_good_flame_game
MIT License
85 stars 11 forks source link

feat: add poppins font #27

Closed wolfenrain closed 1 year ago

wolfenrain commented 1 year ago

Description

Closes #26

Type of Change

wolfenrain commented 1 year ago

You also need to add the font file and the license on license registry right?

Discussed it with @felangel and we wont be adding the font to the bundle as it would increase the size even further, and people tend to rip it out anyway.

erickzanardo commented 1 year ago

You also need to add the font file and the license on license registry right?

Discussed it with @felangel and we wont be adding the font to the bundle as it would increase the size even further, and people tend to rip it out anyway.

Should we even use google fonts then? ๐Ÿค”

wolfenrain commented 1 year ago

Should we even use google fonts then? ๐Ÿค”

For the sake of showing off that you can do anything with flame, yea?

erickzanardo commented 1 year ago

Should we even use google fonts then? ๐Ÿค”

For the sake of showing off that you can do anything with flame, yea?

Yeah, but I mean, if we don't add the font file, this will not work, so what is the point in adding it? But @felangel pointed out that the google_fonts can fetch the file over http in runtime, something I didn't know. So Ignore me haha.

Still, the licence registry we should add? Since this is a recommendation of the google_fonts package?

felangel commented 1 year ago

Should we even use google fonts then? ๐Ÿค”

For the sake of showing off that you can do anything with flame, yea?

Yeah, but I mean, if we don't add the font file, this will not work, so what is the point in adding it? But @felangel pointed out that the google_fonts can fetch the file over http in runtime, something I didn't know. So Ignore me haha.

Still, the licence registry we should add? Since this is a recommendation of the google_fonts package?

Yeah makes sense to add the license imo

wolfenrain commented 1 year ago

Well there is no way to do that without adding the license as an asset itself. So we need to do that then