chore: Remove V1 Embedding from Plugin Template

VeryGoodOpenSource / very_good_templates

Collection of open-source templates created and maintained by Very Good Ventures.

70 stars 15 forks source link

chore: Remove V1 Embedding from Plugin Template #109

Closed tomarra closed 3 months ago

tomarra commented 5 months ago

Description

This is a cleanup task based on the Flutter 3.22 release notes.

"we recommend that plugin authors release updated versions of their plugins with the v1 code removed as soon as possible, to avoid breakage in future versions of Flutter".

Requirements

[ ] No functional changes to the code
[ ] The V1 embedding code is removed from the plugin template

alestiago commented 5 months ago

Referencing:

What's new in Flutter 3.22
Supporting the new Android plugins APIs migration guide
Relevant Flutter commit

alestiago commented 3 months ago

It seems that the V1 code has been removed from the Very Good Flutter Plugin template. I followed the migration documentation and nothing caught my eye in Very Good Flutter Plugin that was related to V1 embedding, in addition we're not getting the warnings anymore so I think we're good.

alestiago commented 3 months ago

Moving this to "In Review", would like to get @wolfenrain's pair of eyes before closing.

tomarra commented 3 months ago

Assigning myself and @wolfenrain to this so we can be the second pair of eyes on this and confirm that we don't need any changes here

tomarra commented 3 months ago

Agree with the comments from @alestiago. Going to close this out as completed.