chore: Update Very Good Flutter Plugin for Recommended Plugin DSL

VeryGoodOpenSource / very_good_templates

Collection of open-source templates created and maintained by Very Good Ventures.

61 stars 11 forks source link

chore: Update Very Good Flutter Plugin for Recommended Plugin DSL #122

Closed tomarra closed 2 months ago

tomarra commented 3 months ago

Description

Coming out of #108. Need to update the Very Good Flutter Plugin to be using the new recommended Plugin DSL to ensure we don't give errors going forward.

Requirements

[ ] The Very Good Flutter Plugin is updated to use the recommended plugin DSL. More details can be found at https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block

alestiago commented 2 months ago

What's interesting is that Flutter plugin template is still using the old syntax.

They have a migration guide, it seems they might have forgotten to update their template. I've raised https://github.com/flutter/flutter/pull/152229, to see if either if that's the case or if there is a deeper reason to why they're not using the plugin DSL syntax.

tomarra commented 2 months ago

Talked through this ticket at planning today. Going to un-draft the PR and get it reviewed so we can get our issue fixed. In parallel the PR on the Flutter team is open and we can work on the side as it doesn't effect our implementation, its just the nice thing to get fixed :)

alestiago commented 2 months ago

Closing as completed by #153