search

VerySleepy / verysleepy

Very Sleepy, a sampling CPU profiler for Windows
http://www.codersnotes.com/sleepy
GNU General Public License v2.0
1.05k stars 103 forks source link

Allow disabling symbol resolution for some modules #112

Closed UnrealKaraulov closed 1 year ago

UnrealKaraulov commented 1 year ago

https://github.com/VerySleepy/verysleepy/issues/109

UnrealKaraulov commented 1 year ago

@CyberShadow need Your help :)

CyberShadow commented 1 year ago

I can't test it but the diff looks good. Actually I would suggest to simplify it a little. The module list can just be a hidden option (and stored together with all options), for example as a string separated by |, then there's no need to do file I/O.

CyberShadow commented 1 year ago

need Your help :)

What do you need help with, does it not work for you?

UnrealKaraulov commented 1 year ago

@CyberShadow Can it be merged, or do I need to make changes?

CyberShadow commented 1 year ago

I can merge this as is. But just so we understand each other...

  1. Do you agree with the suggestion above (regardless of who implements it)? If not, maybe I misunderstood something?
  2. Do you want to stop working on this and get it merged as is?
UnrealKaraulov commented 1 year ago

@CyberShadow as need for project owner:)

but I don't know how to add command line parser, it works for me as is, but you can improve it if needed

CyberShadow commented 1 year ago

I don't think we need a command line parser. My idea was to replace the file reading with wxString::split.

Also it would be nice to have a menu option (e.g. in the right-click menu) to toggle symbol resolution in the selected function's module, that would allow removing all other GUI for the option (so no changes in the options dialog window). Does that make sense to you?

UnrealKaraulov commented 1 year ago

I don't think we need a command line parser. My idea was to replace the file reading with wxString::split.

Also it would be nice to have a menu option (e.g. in the right-click menu) to toggle symbol resolution in the selected function's module, that would allow removing all other GUI for the option (so no changes in the options dialog window). Does that make sense to you?

First I tried to add 'ignore module' to context menu, but it not works, I think because is not reloaded ? (I just don't know how to works code in this tool)

In this PR i just added read file beforce profile started.

Yes I think it can be easy replaced to string::split without problems but I removed project from HDD ) You can do it without me...)

I'm leaving this PR! I'm leaving this PR!

CyberShadow commented 1 year ago

OK, thanks! I will have a closer look at this when I'm home and have access to my Windows development VM.

UnrealKaraulov commented 1 year ago

@CyberShadow ........

CyberShadow commented 1 year ago

I forgor 💀