search

VerySleepy / verysleepy

Very Sleepy, a sampling CPU profiler for Windows
http://www.codersnotes.com/sleepy
GNU General Public License v2.0
1.05k stars 103 forks source link

Fix build error on VS 2022 #117

Open chen3feng opened 1 year ago

chen3feng commented 1 year ago

Fix #115

chen3feng commented 1 year ago

I'm also done with the Command Line feature in the process selection list(#116), but it will be pushed as a separated PR.

CyberShadow commented 1 year ago

I'm also done with the Command Line feature in the process selection list(#116), but it will be pushed as a separated PR.

OK, then I guess you did not intend to include it in this PR.

What about the wine submodule? I don't have the newer commit. Was it an intentional change? If so, please submit a PR to that repository first.

CI (AppVeyor) needs to be green before anything can be merged, so ensuring that CI builds continue working is going to have to be a part of this.

chen3feng commented 1 year ago

Thank you for your rapid response.

I will try to do the missing work tomorrow.

On Tue, Aug 15, 2023, 22:37 Vladimir Panteleev @.***> wrote:

I'm also done with the Command Line feature in the process selection list(

116 https://github.com/VerySleepy/verysleepy/issues/116), but it will

be pushed as a separated PR.

OK, then I guess you did not intend to include it in this PR.

What about the wine submodule? I don't have the newer commit. Was it an intentional change? If so, please submit a PR to that repository first.

CI (AppVeyor) needs to be green before anything can be merged, so ensuring that CI builds continue working is going to have to be a part of this.

— Reply to this email directly, view it on GitHub https://github.com/VerySleepy/verysleepy/pull/117#issuecomment-1679044008, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAPH4SUNPMBPWW7EEA3RFCTXVOCUHANCNFSM6AAAAAA3Q5RU74 . You are receiving this because you authored the thread.Message ID: @.***>

chen3feng commented 1 year ago

Hi, I have implemented the feature #116 which show command line and window title in the process list.

image

But I met some problems to make a PR:

I'm using Visual Studio 2022 to build this project, after I open this project, it let me upgrade all vcproj files to 2022, otherwise there are build errors:

C:\Program Files\Microsoft Visual Studio\2022\Professional\MSBuild\Microsoft\VC\v170\Microsoft.CppBuild.targets(456,5): error MSB8020: The build tools for Visual Studio 2010 (Platform Toolset = 'v100') cannot be found. To build using the v100 build tools, please install Visual Studio 2010 build tools.  Alternatively, you may upgrade to the current Visual Studio tools by selecting the Project menu or right-click the solution, and then selecting "Retarget solution".

I tried to download and install the Visual Studio 2010 build tools, but it is already outdated, MS doesn't provide it.

I can upgrade submodules which are belong to VerySleepy, but wxWidgets is not a part of VerySleep project, if I upgrade them to VS 2022 projects, I don't know how to issue a PR to them.

Even if I only fix this build error, I also met this problem.

CyberShadow commented 1 year ago

Sorry, I don't know how to help you here, except for two things:

  1. The build works in AppVeyor, I'm not sure but maybe it would be worth trying to replicate that known-working build environment.

  2. I can upgrade submodules which are belong to VerySleepy, but wxWidgets is not a part of VerySleep project, if I upgrade them to VS 2022 projects, I don't know how to issue a PR to them.

    Maybe check if a newer wxWidgets version is available which does have the right project files, in which case upgrading the wxWidgets version used by Very Sleepy would make sense. If not, you could also place the upgraded project files in the Very Sleepy repository, outside the wxWidgets submodule.

chen3feng commented 11 months ago

I can't make any progress on this issue due to this blocking issue, anyone can help me?

Here is some more information, FYI:

https://developercommunity.visualstudio.com/t/windowstargetplatformversion-makes-it-impossible-t/140294

chen3feng commented 11 months ago

Maybe I don't make any changes on the VS version, disregard my local build, just make the CI happy?

top-master commented 4 months ago

"don't make any changes on the VS version"

Many projects meet those issues, since VS build-system tries real hard to be incompatible, but you shouldn't let that discourage you:

Or even without CMake:

"Visual Studio 2010 ... MS doesn't provide it."

Internet has many unofficial backups.