search

Vets-Who-Code / js-web-path-mountainmort

MIT License
3 stars 0 forks source link

feat: initial site layout #14

Closed mountainmort closed 1 year ago

mountainmort commented 1 year ago

Tracking progress against Standards in #3 :

In a Pull Request (PR) create a HTML webpage with the following:

  • [x] three different types of headings
  • [x] two paragraphs with three different kinds of inline elements
  • [x] A br and a hr
  • [x] A header and footer
  • [x] Two different sections
  • [x] An unordered list of three items
  • [x] An anchor tag with a link
  • [x] A Form with a textarea, three types of inputs` and a button
  • [x] A table with three columns and three rows with a header, body, and footer

Up next:

axecopfire commented 1 year ago

Hey there, I was thinking for the new class we can add this as well. Can you try and deploy this repo to netlify? That way with these PRs we can get deploy previews. I don't believe it requires a credit card or anything like that.

https://docs.netlify.com/welcome/add-new-site/

netlify[bot] commented 1 year ago

Deploy Preview for vwc-mountainmort ready!

Name Link
Latest commit e44abc3944c688c076fc9ba434c1491a4b4ad7c5
Latest deploy log https://app.netlify.com/sites/vwc-mountainmort/deploys/63d929a0d0c5710008b8c492
Deploy Preview https://deploy-preview-14--vwc-mountainmort.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mountainmort commented 1 year ago

@axecopfire - Pushed up a new Contact me page and made a few tweaks that should fulfill the remaining requirements for #3.

axecopfire commented 1 year ago

It looks great, you are using the id attribute quite a lot. The id is for targeting 1 single specific element on the page. You should be using class for things like section-content and section-logo. https://www.w3schools.com/html/html_classes.asp

The value of the id attribute must be unique within the HTML document. https://www.w3schools.com/html/html_id.asp

Good job on going above and beyond. The distinction will become clearer when we get to CSS.