Vets-Who-Code / js-web-path-mountainmort

MIT License
3 stars 0 forks source link

feat: js dom, js async, nodejs #17

Closed mountainmort closed 1 year ago

mountainmort commented 1 year ago

This PR fulfills the standards in JS DOM Manipulation #7 :

And with the second commit, it also fulfills requirements for Async Javascript #8:

To fire off the API Request for #8, click on this button at the bottom of the page. It will dynamically add a new section to the page and populate a table with the data: image

Additional commit added here, fulfills requirements for Nodejs #9. To run the local node code, you'll need to pull this local and run yarn nodetest in the console (unless there's a way to access the console via Netlify?).

Quick note: to get the deploy preview to work, I had to make a few minor tweaks to the Netlify deploy settings. image

netlify[bot] commented 1 year ago

Deploy Preview for vwc-mountainmort ready!

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/vwc-mountainmort/deploys/63f4fc13d07b3d007cbf1c8b
Deploy Preview https://deploy-preview-17--vwc-mountainmort.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

axecopfire commented 1 year ago

I'll add a TODO for having a copy pasta Github hook that could run npm run test and show the results in PRs. I was thinking that it could be cool to just have a single VWC Github action that we'd add and say "Just add this Githubissues.

  • Githubissues is a development platform for aggregating issues.