Updated Nav Donate Link

Description

Deleted out the span included within the Nav Donate link.

Related Issue

Issue #338

Motivation and Context

This change enhances the lighthouse accessibility score by removing a span that did not meet the 4:1 color ratio compliance.

How Has This Been Tested?

Executed the lighthouse report on localhost. Accessibility score is at 100. I did go back and double check the website and it too has the same score and does not flag the span anymore. Not sure if you'd still wish to merge this PR.

This update does affect the underline on hover transition for the Donate link.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

Vets-Who-Code / vets-who-code-app