added presentaion role to icons

AyolaM commented 2 years ago

Description

Removed icon from accessibility tree.

Related Issue

In compliance accessibility

Motivation and Context

to be compliance accessibility requirements https://fontawesome.com/v5/docs/web/other-topics/accessibility

How Has This Been Tested?

Ran through wave npm test

Screenshots (if appropriate):

Types of changes

no visible changes

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x ] I have added tests to cover my changes.
[x ] All new and existing tests passed.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vetswhocode-web-app/vets-who-code-app/7sAewSNNP6tcSH22N4HdjfMqxXv4
✅ Preview: https://vets-who-code-app-git-amgqo-addariaroles-vetswhocode-web-app.vercel.app

jeromehardaway commented 2 years ago

@jeromehardaway The lock file was updated here, it shouldn't be updated this often unless we are adding new modules, Can we verify everyone is on the correct version of node and also debug what is the root cause of this change?

@andrew-t-james They have all been instructed how to correctly do the install via the directions on the readme. You want to jump on a call with them?

Vets-Who-Code / vets-who-code-app