Closed Cameron-Porter closed 2 years ago
vercel[bot]
commented
2 years ago This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/vetswhocode-web-app/vets-who-code-app/GTmDgwmipSkX9oxD9ngqjvLth7q1
✅ Preview: https://vets-who-code-app-git-cporter-footertest-vetswhocode-web-app.vercel.app
vercel[bot]
commented
2 years ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| vets-who-code-app | ✅ Ready (Inspect) | Visit Preview | May 4, 2022 at 4:02PM (UTC) |
Cameron-Porter
commented
2 years ago Pushed some changes. Updated so footer contact form uses same API endpoint as the normal contact form. Updated the main description with additional details. Please let me know if I need to revisit or refactor anything.
@andrew-t-james / @ajames14-chwy
Cameron-Porter
commented
2 years ago Closing due to multiple files populating from merge. Re-pushing new PR for Andrew's review.
Description
Full update...Updated to only use contact api and not add a second redundant one for the footer contact. Removed the requirement for name and phone, but placed default values for when the footer contact is used. HTML semantics should still cover the contact form as a whole.
Related Issue
259
Motivation and Context
How Has This Been Tested?
Updated tests and all passed for footer contact form. The contact form did have an issue and I was able to update it to check only a param required by both forms. Passing now. But please let me know if we need to revisit this.
Screenshots (if appropriate):
Types of changes
Checklist: