Vexcited / better-spotify-genres

A fork of Spotify-Genres from Tetrax-10 to support latest Spotify.
MIT License
40 stars 2 forks source link

Clearing the genre of the previous song #1

Closed zeroma25 closed 11 months ago

zeroma25 commented 11 months ago

Thanks for fixing and supporting the Spotify Genres extension! Sometimes, if the current song does not have a genre specified, the genre of the previous song is displayed. Could you add a function to clear the previous genre before prompting for the genre of the current song?

Vexcited commented 11 months ago

No problem !

Do you have an example of the songs you play to have this ? So I can reproduce on my side and implement/test it.

Thanks for the report!

zeroma25 commented 11 months ago

Try running any song with genres and queue this song next: https://open.spotify.com/track/4s28VI3QU9kRBKY5ssorlP The genre of the previous song is displayed for me, since genres are not specified for this artist

Vexcited commented 11 months ago

Those commits should've fixed the issue :

Please, try to refresh the extension and see if it fixed !

zeroma25 commented 11 months ago

The genre of the previous song is also displayed, but it should not be there, since this artist does not have a genre specified Снимок экрана 2023-12-24 175114 Снимок экрана 2023-12-24 175140

"Hide Spotify Genres" -> "Show Spotify Genres" helps Снимок экрана 2023-12-24 175727

Vexcited commented 11 months ago

Uhm, it doesn't do it anymore for me ?

Are you sure the extension got updated ?


Here's what happens on my end

https://github.com/Vexcited/better-spotify-genres/assets/59152884/597dc76c-eb5b-4996-9bf7-7540bcb6cc17

zeroma25 commented 11 months ago

For some reason the version from the marketplace didn't work. Installed it manually and it worked. Thank you!

Vexcited commented 11 months ago

Incredible ! Yeah for some reason the market isn't up-to-date, it's probably due to the fact they use jsdelivr to get the JS script from the repository and their cache takes time before getting updated.

Anyways, thanks you for using better-spotify-genres !