search

Vexcited / better-spotify-genres

A fork of Spotify-Genres from Tetrax-10 to support latest Spotify.
MIT License
40 stars 2 forks source link

CSS Grid template issue in Player #2

Closed VPNforWindowsSub closed 10 months ago

VPNforWindowsSub commented 11 months ago

image

Vexcited commented 11 months ago

Thanks for reporting ! I thought having fixed this but seems like their grid usage is weird.

Will look at it asap!

Vexcited commented 11 months ago

Strange, it doesn't look to trigger on my side ?

Does it happen only on some kind of condition ?

image

VPNforWindowsSub commented 11 months ago

I think it's not about the specific song. My guess is that when the song loads a little slower, the genre appears next to the title and artist instead of under it because the genre loaded faster than the actual song. When you quickly click on some song in the list, that may happen. (of course, internet connection speed matters).

https://github.com/Vexcited/better-spotify-genres/assets/73077542/0b7f62cf-f2eb-4cca-b87d-fb5342b5c624

Vexcited commented 11 months ago

Oh I see ! Let me see if I get that by enabling the network limiter on the DevTools

Vexcited commented 11 months ago

No matter what I try, I can't seem to replicate hm...

If you're able to open the devtools and see what's happening (or just record a video showing what the DOM nodes look like (with their CSS) in that player), I'd maybe able to figure out a fix.

Thanks, and sorry

VPNforWindowsSub commented 11 months ago

I'm not an expert, but take a look and see if this helps. If you need anything else, just let me know, and I'll send it to you.

https://github.com/Vexcited/better-spotify-genres/assets/73077542/674c3160-d7e3-4280-968d-07ae40e9c21b

VPNforWindowsSub commented 11 months ago

This is the full DOM node:

Head.txt Body.txt Page source.txt

Vexcited commented 11 months ago

As I can see, there's effectively an issue in your DOM.

Let me show you how it should look like :

image

As you can see in my screenshot, the track info container should've this grid-template property set up. For absolutely no reason, it didn't happened on your DOM...

Let me investigate, I guess

Vexcited commented 11 months ago

Can you record the DevTools on that exact node before the issue happens and then proceed to do the issue with the DevTools opened next to the Spotify window so we can see in real time what's happening.

I think the container gets updated/re-rendered and that makes my style property go away (with the grid patch :/)

VPNforWindowsSub commented 11 months ago

I just removed it from the marketplace and installed it manually, but I still have that issue. Page source 2.txt

VPNforWindowsSub commented 11 months ago

here is the before and after video:

https://github.com/Vexcited/better-spotify-genres/assets/73077542/4e6c3c1e-e09c-4f41-b700-fca619f519de

Vexcited commented 11 months ago

I don't know what the hell happened here but now we know exactly why the issue happens 😂

I think the container gets updated/re-rendered and that makes my style property go away (with the grid patch :/)

So I was right, now I have to find a workaround for that possibility.

Vexcited commented 10 months ago

Can you please, retry now ? (using the manual method in case it didn't work to make sure the marketplace isn't outdated)

Just made a new build to fix this specific issue (https://github.com/Vexcited/better-spotify-genres/commit/336f2d597573116bd38482134c3ced9618860094)

VPNforWindowsSub commented 10 months ago

Thanks for your efforts; it seems the issue has been resolved.