Vexcited / better-spotify-genres

A fork of Spotify-Genres from Tetrax-10 to support latest Spotify.
MIT License
40 stars 2 forks source link

Not showing genres #4

Closed lstres closed 9 months ago

lstres commented 9 months ago

The extension isn't working including the original spotify genres, it shows that music icon to toggle genres but it is not showing any genre. Here is a screenshot image and the image when the genres are on image So as you can see the liked button and music button is pushed to side by 10 pixels. That's the only visual change I can notice

EDIT: One more thing, I have this problem for a pretty long time now, but after i reinstalled my windows 11 and downloaded spotify then spicetify. It was working again now it is not. It has been only 2 weeks i guess

lstres commented 9 months ago

I have also tried installing it manually, still the same issue

matthewyuc commented 9 months ago

same problem

Vexcited commented 9 months ago

Seems like Spotify changed something in the layout so it just won't appear, I'll look into this this afternoon!

lstres commented 9 months ago

Thanks, btw now I can say that I got this bug after updating spotify about 2 days ago

Vexcited commented 9 months ago

Hm, sadly I can't reproduce it on my Spotify installation on Linux, I tried to upgrade everything but it seems like I don't have anything breaking on my side...

image

If anyone can show what the HTML of the player info container looks like (with devtools), I would be very useful !

lstres commented 9 months ago

image here is a screenshot, btw you've got a nice desktop setup

lstres commented 9 months ago

image it seems like this thing have to do something with the genres, html isn't my thing lol

Vexcited commented 9 months ago

Thanks! Well, there's no update in the layout and it in fact works perfectly the way it should...

The only issue is that tags aren't pushed to the <div ... grid-area: genres ...></div> that I create manually 🤔

Is anything showing in the console when you change songs ? Like an error ?

lstres commented 9 months ago

image changing doesn't give any error, but these are some previous errors

Vexcited commented 9 months ago

Hm, it's not related sadly...

Vexcited commented 9 months ago

Let me try to write a custom extension for your case with a bunch of console.log everywhere to see where it hangs :sob:

lstres commented 9 months ago

that seems like a lot of work ig, no hurry from me. I didn't even notice this but today when I wanted to see the genre of a new song. Thanks for maintaining this extension ❤️

Vexcited commented 9 months ago

Can you please try with this one and screen whatever shows up in logs ? https://drive.google.com/file/d/1qjdeTiisyOEoOXHw-oLQ69AXfrepMzY8/view?usp=sharing

Thanks you!

lstres commented 9 months ago

can I just replace the genres file in extensions? I actually tried installing it manually.

Vexcited commented 9 months ago

Yes you should do it that way, and reload the spicetify plugins after

lstres commented 9 months ago

image here it is

lstres commented 9 months ago

this at the last image

Vexcited commented 9 months ago

Alright, I kinda see what's going on now, let me see what I can do on my end

Vexcited commented 9 months ago

I would need more info (again) because I don't see why it would fail ! All of the following should be ran in DevTools while on Spotify (when you're playing a song)

  1. Spicetify.Player.data.item.metadata.artist_uri what's the output ?
    • You should have something looking like this spotify:artist:xxxxxxxxxxxxxxxxxxxxx
  2. Now save the xxxxxxxxxxxxxxxxxxxxx part from 1. and drop it in the following command : await Spicetify.CosmosAsync.get("https://api.spotify.com/v1/artists/xxxxxxxxxxxxxxxxxxxxx"), replacing xxxxxxxxxxxxxxxxxxxxx by the ID from part 1.

If everything went well you should be able to see genres in the output, like this : image

If all the commands worked well, then this issue is mysterious because that's literally the process I use to have genres in the extension, so if you can do it all by hand there's no reason the extension can't do it !

Switchbladd commented 9 months ago

image Same error for any artist & for random symbols too Artist's page normally opens in browser with same artist url so idk Edit: spotify info image

lstres commented 9 months ago
  1. The output is 'spotify:artist:7Ln80lUS6He07XvHI8qqHH'
  2. I got an error instead of receiving genres: image it was 1 am for me yesterday so I had to sleep that's why pretty late. ig we have a big time difference
Vexcited commented 9 months ago

Wow ok, so both of you all got this error ...

Just checked Spicetify issues and found this https://github.com/spicetify/spicetify-cli/issues/1537#issuecomment-1079714623

Feels like I'd need to find a workaround for this case

Switchbladd commented 9 months ago

image https://github.com/spicetify/spicetify-cli/issues/2844 Looks like all CosmosAsync extensions died, so you & we prolly just need to wait for their solution/response Edit: strange that it works for you, what's your spotify version?

Vexcited commented 9 months ago

For now, I pushed yesterday a "fix" that uses Last.FM genres instead of Spotify's genres from artists : https://github.com/Vexcited/better-spotify-genres/commit/5e5c3fed51a4341eaf402ae5101ba9c26f490487

The sad thing is that it covers way less songs but works for popular ones.

I'll lookup for an alternative request and will add my solution here if I find one !

In the meantime, use the latest version with Last.FM genres (sorry for the waiting)

Vexcited commented 9 months ago

What's your spotify version?

image

Seems like the Linux repository is locked at version 1.2.26.1187 for now : see http://repository.spotify.com/dists/testing/non-free/binary-amd64/Packages

That's why I don't have this issue yet, wonder when Spotify will upgrade their repository...

lstres commented 9 months ago

so do we need to downgrade? it will update automatically again 😂

Vexcited commented 9 months ago

If you do want to have it absolutely working right now, yes downgrading is the only option, but as I said, I'll try to find another alternative to get those genres somehow...

Also, the push I did for using Last.FM genres should work for all versions, so you can still have some genres (if the artist is not unknown :sob:)... You just won't have the Spotify fallback, sadly

(Build for the Last.FM push : https://github.com/Vexcited/better-spotify-genres/blob/e3dbc344727694c96e841dbd7a97410c9b0de50c/spotifyGenres.js)

lstres commented 9 months ago

thx for the last fm build, i'm sure there will be some other way

rxri commented 9 months ago

hiya, v2.32.0 should fix this issue. It has been resolved by https://github.com/spicetify/spicetify-cli/pull/2846

lstres commented 9 months ago

Thanks for telling ❤️

Vexcited commented 9 months ago

No way ! So everything works like before for you all now ?

If yes, then I'll let the OP close the issue :')

lstres commented 9 months ago

for me, it does work like before

lstres commented 9 months ago

accidently closed, sorry 😅

Vexcited commented 9 months ago

I mean, if anybody else don't have the issue anymore too, you can close it !

If someone faces again this issue, they'll probably write it here (so I'll just reopen it) or open a new issue

Thanks !

stebo02 commented 9 months ago

It works but now it's showing Last FM tags in favour of genres:

Screenshot 2024-02-21 113549

Screenshot 2024-02-21 113620

It seems to only show the genres in the player bar when there's no Last FM tags available.

Vexcited commented 9 months ago

True! Will revert this behavior in the afternoon, sorry for the inconvenience

Vexcited commented 9 months ago

@stebo02 done ! Update your extension and it should be back like before.

Re-implemented in https://github.com/Vexcited/better-spotify-genres/commit/48dea105b805a8d0b10789f8845efde8246d3465