search

Vexcited / better-spotify-genres

A fork of Spotify-Genres from Tetrax-10 to support latest Spotify.
MIT License
39 stars 1 forks source link

[Bug] The genre list appears twice #9

Closed RashiqAzhan closed 1 month ago

RashiqAzhan commented 1 month ago

Window is small enough to make the genre list scrolls. image

The genre list appears twice for me.

Window is large enough to not make the genre list scrolls. image

Any ideas on how to fix this?

RashiqAzhan commented 1 month ago

It seems this is due to a conflict with this extension. Any way to get the artist recommendation from the "What's That Genre?". That extension doesn't currently identify the genre of all songs like this one does.

Vexcited commented 1 month ago

That extension doesn't currently identify the genre of all songs like this one does.

Concerning better-spotify-genres, the genres are grabbed directly from the Spotify API without any third party API.

In the extension you linked, it seems like they have their own API (https://github.com/LucasOe/spicetify-genres/tree/main/api ?)

That's why some songs don't have genres, it's just the fact that Spotify still didn't put any genre on the artist you're listening to.

Concerning the issue, not sure how to resolve it if that's really a conflict with another extension.

RashiqAzhan commented 1 month ago

Thank you for the response. Is an artist recommendation feature based on the genre ever in the cards or out-of-scope for the project?

Vexcited commented 1 month ago

I think it's out of scope since I can't get this data from the Spotify API.

After analyzing their code, they grab artist data and everything from their own API, see https://github.com/LucasOe/spicetify-genres/blob/e5750e06e301a8375a6515d7220a3780051b0689/src/app.tsx#L138-L149, that's why I'm unable to do it here.

RashiqAzhan commented 1 month ago

Understood. I'm closing this issue has it is out of scope. Appreciate the response and thank you for your project!