search

Vexu / arocc

A C compiler written in Zig.
http://aro.vexu.eu/
MIT License
1.15k stars 56 forks source link

Implement target.getPICMode #771

Closed Organ1sm closed 1 month ago

Organ1sm commented 2 months ago

I tried to solve #770, but full implementation of this function is too long. So for now, i have only implemented these two target-related default functions.

I'm unable to verify all the correctness. Could please review this part first? Once It's reviewed and passed, I'll submit the remaining code for target.getPICMode function.

ehaas commented 2 months ago

Other than my one comment I did a quick check of some of the logic and it looks good.

ehaas commented 2 months ago

@Organ1sm Thanks for tackling this! I think it needs a rebase, and then the last thing to do is to remove desired_pic_level and desired_pie_level from Driver since they're handled in a different way now.

Organ1sm commented 2 months ago

@ehaas I have removed the desired_pic/pie_level from the driver and filled in the diagnostic areas needed in the getPICMode function.

Thank you very much for your suggestions during the code review period, which gave me a great experience. I am also very happy to be able to contribute to arocc.

Vexu commented 1 month ago

Thanks! I fixed some small translation errors for you to avoid another review cycle.