search

Vhati / ftl-profile-editor

Profile editor for FTL: Faster Than Light (www.ftlgame.com)
GNU General Public License v2.0
128 stars 30 forks source link

Compatibility with JAVA 11 #115

Open gerw opened 5 years ago

gerw commented 5 years ago

Currently, the profile editor does not run under JAVA 11. I have added some libraries related to JAXB as dependencies and now it works fine with newer versions of JAVA (at least under linux, I did not test other OS).

Vhati commented 5 years ago

On it! Thanks for letting me know. =)

I'll have to make some other changes. The JAXB dependency requires Java 7, so all my nods to Java 6 compatibility need to be raised. Plus Maven's repo servers migrated to TLS 1.2, which raised the minimum build environment to Java 7 anyway. WinXP will require SP2 to run Java 7.

gerw commented 5 years ago

Thank you for your reply. I somehow expected that this is not enough.

To be honest, I do not now anything about JAVA and I just wanted to use the FTL editor :)

jryski commented 4 years ago

Currently, the profile editor does not run under JAVA 11. I have added some libraries related to JAXB as dependencies and now it works fine with newer versions of JAVA (at least under linux, I did not test other OS).

I've been trying to figure out how to do this on ubuntu 20.08... java 11 is basically all that's available, and I've installed maven, but I can't find where you've made these changes, nor can I get maven to build this.

I'm new to git, trying to learn by starting with something I enjoy rather than dry textbook material.

EgorBodnar commented 3 years ago

Good job, @gerw ! Rise the JDK version to 1.7, please. You couldn't build on the 1.6, it is not supported. I've tested it, works well! Good to merge!

timelessthee commented 3 years ago

Awesome! Is there a chance of getting an updated compiled binary that works?

Forceu commented 3 years ago

I forked this PR and released a compiled binary: https://github.com/Forceu/ftl-profile-editor/releases/tag/v28-java11