search

Vheissu / aurelia-cookie

A simplistic ES2015 class for working with cookies in Aurelia (or any modern Javascript application).
MIT License
16 stars 9 forks source link

"aurelia-cookie" is not defined as a module. #21

Open JoshMcCullough opened 7 years ago

JoshMcCullough commented 7 years ago

I have to use this package from my own fork in order to be able to use this package via TypeScript. The TSDs this package exports are not within a module, so I manually create the module (see link above).

Not sure 100% what the fix is here, or if I'm doing something wrong, but I'm surprised more people haven't mentioned this...?

Please advise, thanks!

timmkrause commented 7 years ago

lol. Just figured that out a few minutes ago. Yesterday I wasted 2 hours with that... Ouch! Fixed it the same way as you @JoshMcCullough.

My solution now is that I commit the package with the edited .d.ts. But this needs to be fixed in order to allow a smoother update next time. I mean, all other .d.ts files of Aurelia plugins are also declared as a module, they all do it the same way and this should be consistent across the board.

Wish I would have taken a look here earlier. ;-)

By the way: According to Semantic Versioning switching the name from "Cookie" to "AureliaCookie" is a breaking change which should have led to version 2.0. Bumping the patch number tells me that I don't have to deal with subsequent work after updating a package.

JoshMcCullough commented 7 years ago

Glad you solved it. :-) Good point about the version number.