search

Vhonowslend / StreamFX-Public

StreamFX is a plugin for OBS® Studio which adds many new effects, filters, sources, transitions and encoders! Be it 3D Transform, Blur, complex Masking, or even custom shaders, you'll find it all here.
https://streamfx.vhonowslend.com
GNU General Public License v2.0
3.94k stars 3.03k forks source link

Blur with a "Source" Mask performs double addref #818

Closed Xaymar closed 1 year ago

Xaymar commented 2 years ago

Operating System

(Other)

OBS Studio Version?

27.1

StreamFX Version

0.12.0a1

OBS Studio Log

N/A

OBS Studio Crash Log

No response

Current Behavior

libOBS crashes on exit due to a double free.

Expected Behavior

libOBS should not crash on exit.

Steps to Reproduce the Bug

  1. Create two Scenes, named A and B.
  2. In "B", add any Source.
  3. In "A", add any Source, named "A-1".
  4. To "A-1" add a Blur filter, and set it to use "B" as the Mask.
  5. Close all dialogs.
  6. Close OBS Studio.
  7. Crash due to double destroy.

Any additional Information we need to know?

No response

Xaymar commented 1 year ago

Confirmed still happening on current master at the time of writing. Having a Blur with a source mask results in that mask leaking in the next scene collection silently.