Closed jonasd4 closed 1 year ago
Base: 79.02% // Head: 79.26% // Increases project coverage by +0.23%
:tada:
Coverage data is based on head (
05810d5
) compared to base (40459ca
). Patch coverage: 70.37% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Nice, looks great! Maybe we could we make it backward compatible, i.e. still allowing vissl
as a source when using get_extractor
but printing out a deprecation warning?
@andropar Good Idea, I implemented it in the latest commit.
Previously, the self-supervised learning models that are not included in the Vissl library were added as custom models. This leads to confusion and makes it harder for the user to discover these models. This PR renames the
VisslExtractor
toSSLExtractor
with sourcessl
and depending on the model, loads it either from the Vissl library or the torch hub. This more generic source also allows easier addition of future SSL models which are not included in Vissl.Changes:
VisslExtractor
toSSLExtractor
with sourcessl
barlowtwins-rn50
,vicreg-rn50
to theSSLExtractor
and removed them from custom models