ViCCo-Group / thingsvision

Python package for extracting representations from state-of-the-art computer vision models
https://vicco-group.github.io/thingsvision/
MIT License
157 stars 21 forks source link

Removes separate VISSL caching and adds file_name to torch.hub.load_state_dict_from_url everywhere #179

Closed jonasd4 closed 2 months ago

jonasd4 commented 2 months ago

This PR fixes further issues with torch.hub.load_state_dict_from_url

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.26%. Comparing base (200e047) to head (c087a2a). Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
thingsvision/core/extraction/extractors.py 77.77% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #179 +/- ## ========================================== - Coverage 76.30% 76.26% -0.04% ========================================== Files 40 40 Lines 2055 2056 +1 Branches 262 263 +1 ========================================== Hits 1568 1568 Misses 402 402 - Partials 85 86 +1 ``` | [Flag](https://app.codecov.io/gh/ViCCo-Group/thingsvision/pull/179/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ViCCo-Group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/ViCCo-Group/thingsvision/pull/179/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ViCCo-Group) | `76.26% <77.77%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ViCCo-Group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LukasMut commented 2 months ago

@jonasd4 Could you provide a meaningful description of the PR? It doesn't have to be long. Can be a one-liner.

jonasd4 commented 2 months ago

@jonasd4 LGTM but please add a short description before I approve.

Added the description!