Closed jonasd4 closed 2 months ago
Attention: Patch coverage is 77.77778%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 76.26%. Comparing base (
200e047
) to head (c087a2a
). Report is 7 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
thingsvision/core/extraction/extractors.py | 77.77% | 0 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jonasd4 Could you provide a meaningful description of the PR? It doesn't have to be long. Can be a one-liner.
@jonasd4 LGTM but please add a short description before I approve.
Added the description!
This PR fixes further issues with
torch.hub.load_state_dict_from_url
torch.hub.load_state_dict_from_url
does not perform any caching)barlowtwins
andvicreg
models as in their respectivehubconf.py
also does not set thefilename
attribute and the filename in the url was the same. (e.g. https://github.com/facebookresearch/barlowtwins/blob/main/hubconf.py). These models are now directly loaded from the respective url while providing thefilename
attribute in the load function.