ViCCo-Group / thingsvision

Python package for extracting representations from state-of-the-art computer vision models
https://vicco-group.github.io/thingsvision/
MIT License
157 stars 21 forks source link

add condition to allow tensorflow-macos instead of tensorflow #97

Closed Alxmrphi closed 2 years ago

Alxmrphi commented 2 years ago

Although Lukas said to me in a recent discussion that all contributors use Macs, you must have all solved the tensorflow requirements issue that I and a few others have faced when trying to install THINGSvision on a Macbook. I have to get around this by cloning the repo and manually editing setup.py to allow for tensorflow-macos instead of plain tensorflow and running python setup.py install manually.

This PR adds conditions to both requirements.txt and setup.py to reflect conditional dependency specification (à la PEP508) based on the OS (so the installation doesn't fail if the user has a sufficient version of tensorflow-macos).

This would make it easier for me to keep up to date with the fast-moving pace of this library and hopefully for others who might struggle with the same issues I've faced.