ViMaSter / gdqreminder-mobile

Android app using Vue + Capacitor to keep track of GamesDoneQuick events
https://play.google.com/store/apps/details?id=ke.mahn.gdqreminder
GNU General Public License v3.0
4 stars 0 forks source link

Improved jumpToYoutube functionality #1190

Open styvsx opened 5 months ago

styvsx commented 5 months ago

Feel free to nuke this from orbit if you don't care, this is my first time doing this and just thought it would be a nice quality of life thing for users.

The v2 version of the tracker API actually provides video URL and could result in a better experience for the jumpToYoutube stuff potentially. Here is an example URL for getting an events runs by event Id (https://tracker.gamesdonequick.com/tracker/api/v2/events/47/runs/) results[].video_links[].url where the link_type is "youtube".

If I find time to familiarize myself with the dev environment requirements and vue, I'll try to contribute, but thought I'd mention it if I don't find the time.

https://github.com/ViMaSter/gdqreminder-mobile/blob/195002116e0d88a2b817f03185553ad44c2ad30c/src/components/GDQMain.vue#L85-L100

ViMaSter commented 5 months ago

Very nice! I actually only realized v2 was a thing a few days back and wanted to implement it just to be up-to-date. Wasn't aware they're now integrating YouTube better, this is absolutely something worth integrating! (Also don't downplay yourself, any suggestion is welcome!)

Check out the README to get started. As long as you got Chrome and nvm on your machine, you should be able to work on it; no need for Android Studio or anything.

I can't guarantee when I'm gonna integrate it, but I'm more than happy to give a PR a review, if you decide to give it a shot!