ViViDboarder / vaultwarden_ldap

Automate LDAP invites to Vaultwarden
GNU General Public License v3.0
157 stars 26 forks source link

Add ca-certificate package #162

Closed FabienYt closed 4 weeks ago

FabienYt commented 1 month ago

Add the ca-certificate package because ldaps gives an error when verifying the certificate.

Exemple:

Caused by:
    0: Failed to connect to LDAP server
    1: native TLS error: error:16000069:STORE [...] error:0A000086:SSL routines:tls_post_process_server_certificate:certificate verify failed:../ssl/statem/statem_clnt.c:1889: (unable to get local issuer certificate)
FabienYt commented 1 month ago

Could you merge this PR @ViViDboarder please?

ViViDboarder commented 1 month ago

Thanks for the reminder. Running workflows and can merge when complete.

ViViDboarder commented 1 month ago

Can you rebase and push again? It’s giving a lock file error, which should be resolved on main.

FabienYt commented 1 month ago

I've just tried but it won't push anything because everything is up to date (with force too)

ViViDboarder commented 1 month ago

Oh! I know what it is. You bumped the version in the cargo file but not the lock file. I think if you run make build it will update the lock. Or, you can just update it manually.

FabienYt commented 4 weeks ago

I just installed rust. I run make build, everything is good now!

Updating crates.io index
Locking 1 package to latest compatible version
Updating vaultwarden_ldap v2.0.1 (vaultwarden_ldap) -> v2.0.2
[...]
Compiling vaultwarden_ldap v2.0.2 (vaultwarden_ldap)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.16s
FabienYt commented 4 weeks ago

I've just fixed the hadolint error (DL3008 warning: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>)

ViViDboarder commented 4 weeks ago

Thanks. That should be enough for me to ship. I’ll probably have to suppress the check for this requirement because the versions change too often.

FabienYt commented 2 weeks ago

@ViViDboarder can you release a new version?

ViViDboarder commented 2 weeks ago

Done!